Lucene: Status=Open

40.7 minutes ago 50 comments 0 votes 0 watches github-actions[bot], goankur, gsmiller, iprithv, jimczi, michaeljmarshall, mikemccand, navneet1v, neoremind, uschindler

Description MemorySegmentIndexInput.prefetch() currently uses a power-of-two back off to ... This implementation works well for files that are fully loaded into the page cache, especially ... This scheme also works okay for files that have very low cache hit rates because they rarely escape ...

gsmiller 40.8 minutes ago:	This looks like a good change to me, so I'll contribute my 👍 . Since there's been a lengthy conversation history and multiple people with opinions, I think it's ... But thank you for all the hard work an iterations on this!
michaeljmarshall 1 day ago:	Agreed, there's no need for that case to have special handling. Removed it.

#16778 PR: Fix parallelism cap when current thread is enrolled in concurrent HNSW merge

55.8 minutes ago 1 comments 0 votes 0 watches CH-Abhinav, abernardi597, github-actions[bot]

Closes 16729. Description HnswConcurrentMergeBuilder submitted all of its workers through TaskExecutorinvokeAll ... The intra-merge executor runs a command on the calling thread when it has no spare thread, so when ...

CH-Abhinav 13.7 days ago:

Don't force push please. Write commit message so that everyone can understand.

#16794 PR: Speed up concurrent HNSW merges by joining the smaller graphs

2.4 hours ago 42 comments 0 votes 0 watches HoustonPutman, LantaoJin, Pulkitg64, benwtrent, github-actions[bot], kaivalnp, mayya-sharipova, msokolov

Description ConcurrentHnswMerger never uses the join-set merge from 14331. It initializes the merged graph from the largest input graph and then inserts every other vector ... Only the serial MergingHnswGraphBuilder joins them.

HoustonPutman 2.4 hours ago:	@mayya-sharipova do you want to get this in to 10.6 or do you want to wait for 11.0?
LantaoJin 18.7 hours ago:	cc @HoustonPutman

#16882 PR: Fix FilteredHnswGraphSearcher overshooting the visit limit when bulk-scoring nodes gathered during ...

4.6 hours ago 0 comments 0 votes 0 watches Pranshu-S, github-actions[bot]

Description <!-- If this is your first contribution to Lucene, please make sure you have reviewed the ... If the batch was larger than the remaining limit, this overshot visitLimit by up to one full ...

#16889 PR: ConcurrentMergeScheduler can spawn more merge threads than maxMergeCount

5.4 hours ago 0 comments 0 votes 0 watches github-actions[bot], goingforstudying-ctrl

DescriptionI was looking at #13593 and the race aoli-al described is still there in main: ... So a merge can become pending right between the stall check and getNextMerge(), and merge() happily ... This makes the cap airtight in two spots: - A merge thread asked to schedule more work while we're ...

#16888 PR: Remove more 'success' booleans

6.5 hours ago 0 comments 0 votes 0 watches github-actions[bot], thecoop

Change more of the success == false checks in try blocks to the more modern catch-and-rethrow

#16887: TopFieldCollector returns wrong top hits with document blocks when child documents match

6.6 hours ago 0 comments 0 votes 0 watches salvatorecampagna

Description TopFieldCollector can return the wrong top hits on segments with document blocks when ... In that case the collector stops as soon as a document is not competitive against the bottom of the ... With a parent field only the blocks are sorted, by the key of their parent.