[Save this search]

Status
All
  Closed (41)
  Open (2)
   Won't Fix (1)
   Cannot Reproduce (1)
Issue type
All
  PR (41)
  Issue (4)
Author relation
All
  Contributor (44)
  Member (31)
  None (6)
Created
All
  Past day (0)
  Past 2 days (0)
  Past 3 days (0)
  Past week (0)
  Past month (0)
  Past 3 months (0)
  Past 6 months (0)
  Past year (0)
Updated
All
  Past day (0)
  Past 2 days (0)
  Past 3 days (0)
  Past week (0)
  Past month (0)
  Past 3 months (0)
  Past 6 months (2)
  Past year (2)
Updated ago
All
  > 1 day ago (45)
  > 2 days ago (45)
  > 3 days ago (45)
  > 1 week ago (45)
  > 1 month ago (45)
  > 3 months ago (45)
  > 1 year ago (43)
Comment count
All
  0 (9)
  1 (8)
  2 - 5 (8)
  6 - 10 (10)
  10 - 20 (7)
  > 20 (5)
Reaction count
All
  0 (45)
  1 (0)
  2 - 5 (0)
  6 - 10 (0)
  10 - 20 (0)
  > 20 (0)
Review Requested
All
  dweiss (1)
Mentioned
All
  sabi0 (3)
  mikemccand (2)
  dweiss (1)
  uschindler (1)
  stefanvodita (1)
  s1monw (1)
  jpountz (1)

See all 8...
Reviewed
All
  uschindler (12)
  dweiss (11)
  sabi0 (4)
  stefanvodita (3)
  mikemccand (2)
  kkmr (2)
  rmuir (1)

See all 9...
Commented
All
  sabi0 (15)
  uschindler (12)
  dweiss (11)
  github-actions[bot] (6)
  mikemccand (1)
  rmuir (1)
  stefanvodita (1)

See all 10...
User
All
  asfimport (10629)
  jpountz (2004)
  mikemccand (1945)
  rmuir (1490)
  dweiss (1486)
  uschindler (1293)
  github-actions[bot] (1263)
sabi0 (45)

See all 837...
Last comment user
All
  dweiss (13)
  sabi0 (7)
  uschindler (6)
  github-actions[bot] (5)
  jpountz (1)
  rmuir (1)
Draft
All
  No (41)
Type
All
  test (3)
  enhancement (2)
Labels
All
  Stale (3)
Commits?
All
  No (45)
Reporter
All
  sabi0 (45)
Assignee
All
  dweiss (18)
  Unassigned (15)
  uschindler (12)
  Filters: Status,  Issue type,  Author relation,  Created,  Updated,  Updated ago,  Comment count,  Reaction count,  Review Requested,  Mentioned,  Reviewed,  Commented,  User (sabi0),  Last comment user,  Draft,  Type,  Labels,  Commits?,  Reporter,  Assignee

#13140 PR: Fix MultiTermQueryDocValuesWrapper not propagating QueryVisitor
5 months ago  2 comments  0 votes  0 watches  github-actions[bot]sabi0
    github-actions[bot] 5 months ago:  This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
    github-actions[bot] 2 years ago:  This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

#13142 PR: Replace Collections.synchronizedSet() with ConcurrentHashMap.newKeySet()
5 months ago  25 comments  0 votes  0 watches  benwtrentdweissgithub-actions[bot]sabi0uschindler
ConcurrentHashMap.newKeySet() provides better multi-threaded performance thanks to judicious use of ... Also it does not require "external" synchronization for iteration.
    github-actions[bot] 5 months ago:  This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
    github-actions[bot] 2 years ago:  This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

#13087 PR: Make static final Set constants immutable
1.1 years ago  28 comments  0 votes  0 watches  asfgitdweisskkmrsabi0uschindler
For the mutable "global" Sets changed Collections.synchronizedSet() to ConcurrentHashMap.newKeySet( ...
    dweiss 2 years ago:  Thanks!
    uschindler 2 years ago:  Thanks!

#13060 PR: Remove redundant field initializers
2.1 years ago  9 comments  0 votes  0 watches  github-actions[bot]sabi0stefanvodita
In many cases this allowed to mark the field as final.
    stefanvodita 2.1 years ago:  It's a strange case. We're not really breaking backwards compatibility, since no one could have accessed this field ...
    stefanvodita 2.1 years ago:  Since this class is marked with @lucene.experimental, we can make the change.

#13085 PR: Avoid allocating redundant Strings
2.1 years ago  6 comments  0 votes  0 watches  dweissgithub-actions[bot]sabi0stefanvodita
Removed unnecessary toString() / substring() calls to avoid extra Strings being allocated
    sabi0 2.1 years ago:  Thank you, @stefanvodita
    stefanvodita 2.1 years ago:  Done. I just had to move the CHANGES entry up. @sabi0 - the clean-up work you've been doing is really appreciated!

#13068 PR: Move brToString(BytesRef) to ToStringUtils
2.1 years ago  30 comments  0 votes  0 watches  almogtavorasfgitcpoerschkedweissmikemccandsabi0uschindler
I noticed there are brToString() methods in 16 different classes. What do you think of providing a shared implementation in the ToStringUtils class? If you find the proposal useful I will proceed with removing the other copies.
    uschindler 2.1 years ago:  Backport was easy, no conflicts. I also checked with fgrep -R brToString * but no occurrences found. Thanks @sabi0 !
    uschindler 2.1 years ago:  To the other reviewers: I would like to merge this as a first step. To me this looks fine as it removes the code duplication and we have a better method name. Ok?

#13041 PR: Cleanup TokenizedPhraseQueryNode code
2.1 years ago  11 comments  0 votes  0 watches  github-actions[bot]sabi0stefanvodita
- harmonize implementations of the methods working with children - save getChildren() in a ... renaming that did not update the comment?)
    stefanvodita 2.1 years ago:  This would have to move up to version 9.11 because 9.10 is already in the release process.
    stefanvodita 2.1 years ago:  I think having the two methods aligned, the way they are in your latest commit, makes sense.

[23.6 msec search, 24.6 msec total]